Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetPodsForJob check the pod owner reference job uid #1796

Merged
merged 1 commit into from
May 16, 2023
Merged

GetPodsForJob check the pod owner reference job uid #1796

merged 1 commit into from
May 16, 2023
+12 −37

Conversation

yowenter
Copy link
Contributor

@yowenter yowenter commented Apr 26, 2023 •
edited
Loading

What this PR does / why we need it:
If job is recreated using the deleted job name while the deleted job pods are stuck in Terminating state , the func GetPodsForJob maybe incorrect.

Checklist:

  • Docs included if any changes are user facing

@google-cla
Copy link

google-cla bot commented Apr 26, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@yowenter
Copy link
Contributor Author

yowenter commented Apr 26, 2023 •
edited
Loading

Hi, @tenzen-y (friendly ping ), Could you please have a look ?

tenzen-y
tenzen-y reviewed Apr 26, 2023
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this improvement!
I left a few comments.

pkg/common/util/util.go Outdated Show resolved Hide resolved
pkg/common/util/util.go Outdated Show resolved Hide resolved
pkg/controller.v1/xgboost/xgboostjob_controller.go Outdated Show resolved Hide resolved
@google-oss-prow google-oss-prow bot added size/S and removed size/M labels Apr 26, 2023
@yowenter
Copy link
Contributor Author

Hi, @tenzen-y , I've made some changes, please review again.
And there's also a pull request Pod name using generated name to fix recreated job using the same name issue. Could you review it if you have time?

tenzen-y
tenzen-y reviewed Apr 26, 2023
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for your contribution. I'm looking forward to collaborating more in the future.

/assign @johnugeorge @gaocegege @terrytangyuan

@google-oss-prow google-oss-prow bot added the lgtm label Apr 26, 2023
@tenzen-y
Copy link
Member

And there's also a pull request kubeflow/common#215 to fix recreated job using the same name issue. Could you review it if you have time?

Maybe, I can't review the PR this week since there are many PRs in my review queue.
Thanks for your patience.

@yowenter
Copy link
Contributor Author

And there's also a pull request kubeflow/common#215 to fix recreated job using the same name issue. Could you review it if you have time?

Maybe, I can't review the PR this week since there are many PRs in my review queue. Thanks for your patience.

it’s okay, take your time.

@yowenter yowenter requested a review from tenzen-y April 27, 2023 11:27
tenzen-y
tenzen-y reviewed May 2, 2023
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label May 2, 2023
@coveralls
Copy link

coveralls commented May 15, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4819195351

  • 5 of 11 (45.45%) changed or added relevant lines in 7 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 39.437%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller.v1/mxnet/mxjob_controller.go 0 1 0.0%
pkg/controller.v1/xgboost/xgboostjob_controller.go 0 1 0.0%
pkg/common/util/util.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 76.84%
Totals Coverage Status
Change from base Build 4659763896: -0.02%
Covered Lines: 2731
Relevant Lines: 6925
💛 - Coveralls

@johnugeorge
Copy link
Member

Thanks for cleaning this up @yowenter
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, yowenter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 519d8f2 into kubeflow:master May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@jinchihe jinchihe Awaiting requested review from jinchihe

@kuizhiqing kuizhiqing Awaiting requested review from kuizhiqing

Assignees

@johnugeorge johnugeorge

@terrytangyuan terrytangyuan

@gaocegege gaocegege

@tenzen-y tenzen-y

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yowenter @tenzen-y @coveralls @johnugeorge @terrytangyuan @gaocegege